Skip to content

test: move tempdir creation to util method - #23649

Merged
alan-agius4 merged 1 commit into
angular:mainfrom
jbedard:e2e-tempdir
Jul 28, 2022
Merged

test: move tempdir creation to util method#23649
alan-agius4 merged 1 commit into
angular:mainfrom
jbedard:e2e-tempdir

Conversation

@jbedard

@jbedard jbedard commented Jul 27, 2022

Copy link
Copy Markdown
Contributor

To put the login in a common location. This will allow easily using the bazel temp dir when converting to bazel.

@jbedard
jbedard requested a review from alan-agius4 July 28, 2022 00:45
@jbedard
jbedard marked this pull request as ready for review July 28, 2022 00:45
Comment thread tests/legacy-cli/e2e/utils/utils.ts Outdated
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Jul 28, 2022

@alan-agius4 alan-agius4 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one NIT

@alan-agius4 alan-agius4 added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jul 28, 2022
@jbedard
jbedard requested a review from alan-agius4 July 28, 2022 16:09
@alan-agius4

Copy link
Copy Markdown
Collaborator

@jbedard, can you please squash?

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jul 28, 2022
@alan-agius4
alan-agius4 merged commit acd5ad5 into angular:main Jul 28, 2022
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Aug 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants